Use access token to authenticate with the Google Cloud. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using GitHub actions or other CI/CD platform, the user may not be able to run `gcloud init` interactively. The recommended login for those kinds of deployments is to get an access token from Google Cloud, store it as a secret and use it for deployments. This change adds support for using such tokens for deployment, either by passing an "access_token" flag to the `weaver-gke` commands, or by setting the CLOUDSDK_AUTH_ACCESS_TOKEN variable when invoking the commands. Other changes: * Unify flag handling for the cloud flags across all commands. * Remove project and account fields from the `GKEConfig` proto. * Minor cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using GitHub actions or other CI/CD platform, the user may not be able to run
gcloud initinteractively. The recommended login for those kinds of deployments is to get an access token from Google Cloud, store it as a secret and use it for deployments. This change adds support for using such tokens for deployment, either by passing an "access_token" flag to theweaver-gkecommands, or by setting the CLOUDSDK_AUTH_ACCESS_TOKEN variable when invoking the commands.Other changes:
GKEConfigproto.